Add historic metrics #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scripts for db, update metrics.json file structure
DimaStebaev
reviewed
Sep 17, 2024
badrogger
approved these changes
Sep 18, 2024
metrics/src/db.py
Outdated
| BACKFILL_DB_DAYS = 30 | ||
|
|
||
|
|
||
| async def get_current_total_transactions(session, chain_name: str, address: str) -> int: |
There was a problem hiding this comment.
I think it is better to move this method into src.explorer
metrics/src/gas.py
Outdated
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def init_w3(): | ||
| logger.info(f'Connecting to {ENDPOINT}...') | ||
| logger.info(f"Connecting to {ENDPOINT}...") |
There was a problem hiding this comment.
Why double-quotes, but not single-quotes in this module?
metrics/src/main.py
Outdated
| def run_migrations(): | ||
| logger.info('Running database migrations...') | ||
| try: | ||
| from models import Address, TransactionCount |
There was a problem hiding this comment.
Move models import to the other imports
| logger.info('Metrics collector iteration started...') | ||
| current_date = datetime.now().date() | ||
|
|
||
| if last_run_date is None or current_date > last_run_date: |
There was a problem hiding this comment.
If you are running collect_metrics at the beginning of the day, then in daily_transactions field for this date in db will be in fact daily transactions count from the previous day. Is it supposed to work like this?
metrics/src/db.py
Outdated
Comment on lines
33
to
34
| TRANSACTION_COUNT_FIELD = 'transactions_count' | ||
| BACKFILL_DB_DAYS = 30 |
There was a problem hiding this comment.
Probably it's better to move db constants to src/config.py
DmytroNazarenko
approved these changes
Sep 19, 2024
DmytroNazarenko
approved these changes
Sep 20, 2024
badrogger
approved these changes
Sep 20, 2024
DmytroNazarenko
approved these changes
Sep 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: