Add support for map of contract addresses in getInstance function #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavrsky
changed the title
yavrsky
changed the title
yavrsky
changed the title
DimaStebaev
reviewed
Jan 8, 2025
typescript/base/src/project.ts
Outdated
| if (this.network.adapter.isAddress(aliasOrAddress)) { | ||
| return this.getInstanceByAddress(aliasOrAddress); | ||
| getInstance (target: string | MainContractAddress | ContractAddressMap) { | ||
| const isStringAndAddress = |
There was a problem hiding this comment.
The condition can be simplified.
| getAbiFilename (version: string) { | ||
| return `${this.metadata.name}-${version}-abi.json`; | ||
| } | ||
|
|
||
| createInstance (address: string): Instance<ContractType> { | ||
| createInstance (target: MainContractAddress | ContractAddressMap) |
There was a problem hiding this comment.
Maybe let it be address in assumption that ContractAddressMap is also an "address" in some sense?
For me target is too confusion because it's not clear what to pass.
…for ContractAddressMap
DimaStebaev
reviewed
Jan 8, 2025
| ) { | ||
| this.project = project; | ||
| this.address = address; | ||
| if (typeof address === "string") { |
There was a problem hiding this comment.
Replace with isContractAddressMap?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
Motivation
- No main contract address is defined for a specific project.
- Additional or alternative contract configurations are required for different use cases.
No need for QA to test