Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup skale-manager image after deployment. Fix tests #996

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Oct 10, 2023

Remove skale-manager docker image to reduce occupied disk space.
No source code touched, no performance changes made.

@badrogger badrogger linked an issue Oct 10, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (456bc4d) 80.45% compared to head (b6b09a3) 80.40%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #996      +/-   ##
===========================================
- Coverage    80.45%   80.40%   -0.05%     
===========================================
  Files          100      100              
  Lines         5501     5523      +22     
===========================================
+ Hits          4426     4441      +15     
- Misses        1075     1082       +7     
Files Coverage Δ
core/schains/monitor/action.py 90.32% <100.00%> (-1.32%) ⬇️
core/schains/monitor/containers.py 78.46% <100.00%> (ø)
core/schains/monitor/skaled_monitor.py 92.50% <100.00%> (-0.10%) ⬇️
tools/docker_utils.py 96.20% <81.81%> (-0.75%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review October 10, 2023 14:46
@DmytroNazarenko DmytroNazarenko merged commit 66d9140 into develop Oct 10, 2023
5 of 6 checks passed
@DmytroNazarenko DmytroNazarenko deleted the rmi-sm branch October 10, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare 2.2 builds
2 participants