Merge pull request #168 from skalenetwork/bug/SKALE-4666-unit-tests-fail

Bug/skale 4666 unit tests fail
skalenetwork · Nov 10, 2021 · 385f1f3 · 385f1f3
2 parents 0864991 + 87fd6c4
commit 385f1f3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -132,7 +132,6 @@ jobs:
         export CC=gcc-9
         export CXX=g++-9
         export TARGET=all
-        export CMAKE_BUILD_FLAGS="-DCOVERAGE=ON"
         cd deps
         ./build.sh WITH_EMSCRIPTEN=1
         cd ..

diff --git a/test/test_TE_wrappers.cpp b/test/test_TE_wrappers.cpp
@@ -337,9 +337,12 @@ BOOST_AUTO_TEST_CASE( ExceptionsTest ) {
     BOOST_REQUIRE_THROW(
         libBLS::ThresholdUtils::checkSigners( 0, 0 ), libBLS::ThresholdUtils::IncorrectInput );
 
-    // null public key share
-    BOOST_REQUIRE_THROW( TEPublicKeyShare( nullptr, 1, num_signed, num_all ),
-        libBLS::ThresholdUtils::IncorrectInput );
+    {
+        // null public key share
+        std::shared_ptr< std::vector< std::string > > share_ptr = nullptr;
+        BOOST_REQUIRE_THROW( TEPublicKeyShare( share_ptr, 1, num_signed, num_all ),
+            libBLS::ThresholdUtils::IncorrectInput );
+    }
 
     {
         // 1 coord of public key share is not a number
@@ -568,10 +571,6 @@ BOOST_AUTO_TEST_CASE( ExceptionsTest ) {
     {
         // not enough elements in decrypt set
         TEDecryptSet decr_set( num_signed, num_all );
-        libff::alt_bn128_G2 el1 = libff::alt_bn128_G2::random_element();
-
-        auto el_ptr1 = std::make_shared< libff::alt_bn128_G2 >( el1 );
-        decr_set.addDecrypt( 1, el_ptr1 );
 
         libff::alt_bn128_G2 U = libff::alt_bn128_G2::random_element();
 
@@ -655,12 +654,11 @@ BOOST_AUTO_TEST_CASE( ExceptionsDKGWrappersTest ) {
 
     {
         DKGTEWrapper dkg_te( num_signed, num_all );
-        std::shared_ptr< std::vector< libff::alt_bn128_Fr > > shares =
-            dkg_te.createDKGSecretShares();
-        shares->erase( shares->begin() + shares->size() - 2 );
-        shares->shrink_to_fit();
-        BOOST_REQUIRE_THROW(
-            dkg_te.setDKGSecret( shares ), libBLS::ThresholdUtils::IncorrectInput );
+        dkg_te.createDKGSecretShares();
+
+        std::shared_ptr< std::vector< libff::alt_bn128_Fr > > v;
+
+        BOOST_REQUIRE_THROW( dkg_te.setDKGSecret( v ), libBLS::ThresholdUtils::IncorrectInput );
     }
 
     {