Merge pull request #159 from skalenetwork/bug/SKALE-4693-fix-consensu…

…s-compatibility Bug/skale 4693 fix consensus compatibility
skalenetwork · Oct 21, 2021 · 237e51b · 237e51b
2 parents 4a1e3a1 + 8ffc527
commit 237e51b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/bls/BLSPublicKey.cpp b/bls/BLSPublicKey.cpp
@@ -147,7 +147,8 @@ bool BLSPublicKey::AggregatedVerifySig(
 
 BLSPublicKey::BLSPublicKey(
     std::shared_ptr< std::map< size_t, std::shared_ptr< BLSPublicKeyShare > > > koefs_pkeys_map,
-    size_t _requiredSigners, size_t _totalSigners ) {
+    size_t _requiredSigners, size_t _totalSigners )
+    : t( _requiredSigners ), n( _totalSigners ) {
     crypto::ThresholdUtils::initCurve();
 
     crypto::ThresholdUtils::checkSigners( _requiredSigners, _totalSigners );

diff --git a/bls/BLSPublicKey.h b/bls/BLSPublicKey.h
@@ -33,6 +33,8 @@ class BLSPublicKeyShare;
 class BLSPublicKey {
 private:
     std::shared_ptr< libff::alt_bn128_G2 > libffPublicKey;
+    size_t t;
+    size_t n;
 
 public:
     BLSPublicKey( const std::shared_ptr< std::vector< std::string > > );
@@ -56,6 +58,10 @@ class BLSPublicKey {
     std::shared_ptr< std::vector< std::string > > toString();
 
     std::shared_ptr< libff::alt_bn128_G2 > getPublicKey() const;
+
+    size_t getRequiredSigners() const { return t; }
+
+    size_t getTotalSigners() const { return n; }
 };
 
 

diff --git a/test/test_bls.cpp b/test/test_bls.cpp
@@ -241,6 +241,9 @@ BOOST_AUTO_TEST_CASE( libBlsAPI ) {
                     pkeys_map1 ),
                 num_signed, num_all );
 
+            BOOST_REQUIRE( common_pkey1.getRequiredSigners() == num_signed );
+            BOOST_REQUIRE( common_pkey1.getTotalSigners() == num_all );
+
             BOOST_REQUIRE( common_pkey1.VerifySig( hash_ptr, common_sig_ptr ) );
 
             std::vector< size_t > participants1( num_all );  // use the whole set of participants