Fix community locker contract, add CLI tools #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrotkk
requested review from
DmytroNazarenko,
TheGreatAxios and
sergiy-skalelabs
sergiy-skalelabs
approved these changes
Jan 4, 2024
TheGreatAxios
approved these changes
Jan 4, 2024
|
|
||
| Example: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
For this example, suggest adding some more notes on what each of those values are.
Not sure what the different flags and values represent
There was a problem hiding this comment.
General comment -> Metaport has a specific format enforced so that semi-colons (;) are not used anywhere.
In this file you have a mix and match of lines ending and not ending with (;).
Suggest picking one or the other for long term improved standard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
No additional tests added.
No performance changes.
Resolves skalenetwork/portal#118