Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt #1721

Merged
merged 45 commits into from
Nov 19, 2024
Merged

Tech debt #1721

merged 45 commits into from
Nov 19, 2024

Conversation

yavrsky
Copy link
Contributor

@yavrsky yavrsky commented Nov 12, 2024 •
edited
Loading

What was done:

  • updated dependencies, particularly moved to ethers V6 and upgrade-tools V3
  • fixed upgrade script for mainnet part for compatibility with latest version of upgrade-tools
  • fixed deploy script
  • fixed tests

What wasn't done:

This was linked to issues Nov 12, 2024
Can't update IMA due to gnosis safe api url change #1542
Open
Update dependencies related to gnosis-safe-sdk #1638
Closed
DimaStebaev
DimaStebaev reviewed Nov 13, 2024
View reviewed changes
gas/calculateGas.ts Outdated Show resolved Hide resolved
migrations/deployMainnet.ts Outdated Show resolved Hide resolved
migrations/deployMainnet.ts Outdated Show resolved Hide resolved
migrations/deploySchain.ts Outdated Show resolved Hide resolved
DimaStebaev
DimaStebaev reviewed Nov 13, 2024
View reviewed changes
migrations/upgradeMainnet.ts Outdated Show resolved Hide resolved
scripts/test_deploy.sh Outdated Show resolved Hide resolved
scripts/test_upgrade.sh Outdated Show resolved Hide resolved
test/CommunityLocker.ts Outdated Show resolved Hide resolved
test/CommunityLocker.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
DimaStebaev
DimaStebaev reviewed Nov 18, 2024
View reviewed changes
scripts/test_upgrade.sh Outdated Show resolved Hide resolved
test/TokenManagerEth.ts Outdated Show resolved Hide resolved
test/utils/helper.ts Outdated Show resolved Hide resolved
DimaStebaev
DimaStebaev previously approved these changes Nov 18, 2024
View reviewed changes
@yavrsky yavrsky dismissed stale reviews from DimaStebaev and DmytroNazarenko via 1ad91a2 November 19, 2024 01:03
@DmytroNazarenko DmytroNazarenko merged commit 601d265 into v2.2.0 Nov 19, 2024
6 checks passed
@DmytroNazarenko DmytroNazarenko deleted the tech-debt branch November 19, 2024 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@DimaStebaev DimaStebaev DimaStebaev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't update IMA due to gnosis safe api url change Update dependencies related to gnosis-safe-sdk
3 participants
@yavrsky @DimaStebaev @DmytroNazarenko