Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticket-1610 Fixed - Loop worker doesn't receive connected chains #1611

Conversation

sergiy-skalelabs
Copy link
Contributor

Fixed issue related to 1 hour delay until S2S transfer really start to perform. This happen because SNB worker downloads array of connected chains too fast, broadcasts it to loop worker threads earlier than loop worker threads started.

@sergiy-skalelabs sergiy-skalelabs marked this pull request as ready for review October 6, 2023 18:14
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5256b5e) 85.79% compared to head (dbd1079) 85.79%.

❗ Current head dbd1079 differs from pull request most recent head 56c2c3e. Consider uploading reports for the commit 56c2c3e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1611   +/-   ##
========================================
  Coverage    85.79%   85.79%           
========================================
  Files           26       26           
  Lines         1464     1464           
  Branches       401      401           
========================================
  Hits          1256     1256           
  Misses          33       33           
  Partials       175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DmytroNazarenko DmytroNazarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on devnet

2023-10-06 18:56:13.416: Loop module will do first initial broadcast of arrSChainsCached to its 2 worker(s) in main thread 0...
2023-10-06 18:56:13.416: Loop module will broadcast arrSChainsCached event to its 2 worker(s) in main thread 0...
2023-10-06 18:56:13.416: S-Chains cache will be sent to out_of_worker_client_pipe://ima_loop_server0:a0c78008-69a4-4aa7-8531-0101fe2d85fa loop worker...
2023-10-06 18:56:13.416: S-Chains cache did sent to out_of_worker_client_pipe://ima_loop_server0:a0c78008-69a4-4aa7-8531-0101fe2d85fa loop worker
2023-10-06 18:56:13.417: S-Chains cache will be sent to out_of_worker_client_pipe://ima_loop_server1:82f5a7a4-3276-439a-a46d-3d5fa0faa2e3 loop worker...
2023-10-06 18:56:13.419: S-Chains cache did sent to out_of_worker_client_pipe://ima_loop_server1:82f5a7a4-3276-439a-a46d-3d5fa0faa2e3 loop worker
2023-10-06 18:56:13.420: Loop module did finished broadcasting arrSChainsCached event to its 2 worker(s) in main thread 0...
2023-10-06 18:56:13.420: Done, did started parallel IMA transfer loops in main thread 0, 
...
10-06 18:56:13.420: Will set arrSChainsCached in worker thread 2...
2023-10-06 18:56:13.428: LOOP WORKER ima_loop_server0 S-Chains cache did arrived to ima_loop_server0 loop worker in worker thread 2: [{"data":{"name":"diarra"

@DmytroNazarenko DmytroNazarenko merged commit b8ffa7f into develop Oct 6, 2023
13 of 15 checks passed
@DmytroNazarenko DmytroNazarenko deleted the ticket-1610/Loop-worker-doesnot-receive-connected-chains branch October 6, 2023 19:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loop worker doesn't receive connected chains
2 participants