-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Echancement: BLS signatures are gathered more asynchronously #1594
Merged
sergiy-skalelabs
merged 3 commits into
develop
from
enchancement/BLS-signature-gathering-analysis
Sep 19, 2023
Merged
Echancement: BLS signatures are gathered more asynchronously #1594
sergiy-skalelabs
merged 3 commits into
develop
from
enchancement/BLS-signature-gathering-analysis
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sergiy-skalelabs
commented
Sep 19, 2023
•
edited
Loading
edited
- BLS signatures are gathered more asynchronously
- Prevents BLS signature gathering from being stuck on N-th stopped node
- Speeds up BLS signature gathering
- Human-readable BLS gathering progress is logged
…thering progress is logged
sergiy-skalelabs
requested review from
badrogger,
dmytrotkk,
payvint and
DmytroNazarenko
September 19, 2023 11:49
sergiy-skalelabs
changed the title
echance,ent: BLS signatures are gathered more asynchronously
Echancement: BLS signatures are gathered more asynchronously
Sep 19, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1594 +/- ##
========================================
Coverage 85.79% 85.79%
========================================
Files 26 26
Lines 1464 1464
Branches 401 401
========================================
Hits 1256 1256
Misses 33 33
Partials 175 175 ☔ View full report in Codecov by Sentry. |
badrogger
previously approved these changes
Sep 19, 2023
badrogger
approved these changes
Sep 19, 2023
DmytroNazarenko
approved these changes
Sep 19, 2023
dmytrotkk
approved these changes
Sep 19, 2023
sergiy-skalelabs
deleted the
enchancement/BLS-signature-gathering-analysis
branch
September 19, 2023 14:59
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.