Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header added #69

Merged
merged 3 commits into from
May 31, 2024
Merged

Header added #69

merged 3 commits into from
May 31, 2024

Conversation

siya25097
Copy link
Contributor

##Fixed issue #57
hey, @sk66641 I have added header containing about, features and contact option where due to lack of contact information i was not able to add that information rest of the changes are made successfully.
Uploading Screenshot (1106).png…

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sk66641
Copy link
Owner

sk66641 commented May 30, 2024

@siya25097 have you mixed pr of issue #56 in #57 ?

@siya25097
Copy link
Contributor Author

@sk66641 yes i have made changes of both issue #56 and #57 in #57

@sk66641
Copy link
Owner

sk66641 commented May 31, 2024

@siya25097 it looks nice, but it would be better if you could make the following changes:

  1. make " About and Features" popup responsive like the warning popup
  2. do not add any background-color in header
    after these changes, i'll merge it under gssoc level2

@sk66641 sk66641 merged commit cf1e913 into sk66641:main May 31, 2024
1 check passed
@sk66641 sk66641 added gssoc This Contribution is under GSSOC'24 level2 labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GSSOC'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants