Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Light Pattern Options In website #622

Merged
merged 4 commits into from
Aug 10, 2024
Merged

Updated the Light Pattern Options In website #622

merged 4 commits into from
Aug 10, 2024

Conversation

vivekvardhan2810
Copy link
Contributor

@vivekvardhan2810 vivekvardhan2810 commented Aug 9, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #597

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

image

Copy link

github-actions bot commented Aug 9, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@aditya-bhaumik aditya-bhaumik self-requested a review August 9, 2024 18:26
@aditya-bhaumik aditya-bhaumik requested a review from sk66641 August 9, 2024 18:26
@aditya-bhaumik aditya-bhaumik added gssoc This Contribution is under GSSOC'24 level2 labels Aug 9, 2024
@aditya-bhaumik
Copy link
Collaborator

@sk66641 please review this pull request i am a little busy at the moment

@sk66641
Copy link
Owner

sk66641 commented Aug 10, 2024

will review it before the finishing time

@sk66641
Copy link
Owner

sk66641 commented Aug 10, 2024

@vivekvardhan2810
simulation should not start before successful submission, also there should be an option for user to select none
Screencast from 2024-08-10 11-25-52.webm

@vivekvardhan2810
Copy link
Contributor Author

Ok @sk66641 will make the required changes before the finishing time

@sk66641
Copy link
Owner

sk66641 commented Aug 10, 2024

@aditya-bhaumik
please review this pr after required changes because i might not be able to review it today

@aditya-bhaumik aditya-bhaumik merged commit 196b55e into sk66641:main Aug 10, 2024
1 check passed
@aditya-bhaumik
Copy link
Collaborator

@sk66641 will you be available at 5 as I will be creating some pull requests of my own and 7 is the deadline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GSSOC'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡[Feature]: Add Light Pattern Options In Website
3 participants