Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected multiple pages #612

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Corrected multiple pages #612

merged 1 commit into from
Aug 9, 2024

Conversation

VijaySamant4368
Copy link
Contributor

Description

Corrected all the mentioned ppages

Fixes: #526

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Copy link

github-actions bot commented Aug 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@aditya-bhaumik
Copy link
Collaborator

aditya-bhaumik commented Aug 8, 2024

@VijaySamant4368 please share a working recording of the changes you made as i can see you have removed a lot of media queries

@VijaySamant4368
Copy link
Contributor Author

On it.

@VijaySamant4368
Copy link
Contributor Author

VijaySamant4368 commented Aug 8, 2024

All the changes done can be categorized into two groups:

  • Same width in both the modes:
Screen.Recording.2024-08-08.224747.mp4
  • No extra space in smaller screens:
Screen.Recording.2024-08-08.224909.mp4

@VijaySamant4368
Copy link
Contributor Author

Before changes:

  • Width changes when toggling between modes
Screen.Recording.2024-08-08.225120.mp4
  • Extra space in smaller screens
Screen.Recording.2024-08-08.225225.mp4

@VijaySamant4368
Copy link
Contributor Author

@aditya-bhaumik please kindly have a look.
Thank you.

@aditya-bhaumik aditya-bhaumik requested a review from sk66641 August 8, 2024 18:47
@sk66641
Copy link
Owner

sk66641 commented Aug 9, 2024

@VijaySamant4368
will review it before today night

@sk66641 sk66641 added gssoc This Contribution is under GSSOC'24 level1 bug Something isn't working labels Aug 9, 2024
@sk66641 sk66641 merged commit ae8db3e into sk66641:main Aug 9, 2024
2 checks passed
@VijaySamant4368 VijaySamant4368 deleted the pages branch August 9, 2024 14:19
@sk66641 sk66641 added level2 and removed level1 labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc This Contribution is under GSSOC'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Lots of problems in many web-pages
3 participants