Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed preloader bug #604

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fixed preloader bug #604

merged 1 commit into from
Aug 7, 2024

Conversation

Jasleen1210
Copy link
Contributor

@Jasleen1210 Jasleen1210 commented Aug 7, 2024

The particle and snowflake effect has been fixed in all the side pages.

The issue was that the preloader.css file had "display none" for the content that affected the particle effect, and the snowflake effect was preceeded by warning modal in script.js so that cause error in console.

Ive made a separate file for the preloader js and added the snowflake function in it so that all the pages have the preloader as well as the snowflake thing

Fixes: #591

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

The particle and snowflake effect has been fixed in all the side pages.

The issue was that the preloader.css file had "display none" for the content that affected the particle effect, and the snowflake effect was preceeded by warning modal in script.js so that cause error in console.

Ive made a separate file for the preloader js and added the snowflake function in it so that all the pages have the preloader as well as the snowflake thing
Copy link

github-actions bot commented Aug 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@aditya-bhaumik aditya-bhaumik requested a review from sk66641 August 7, 2024 14:10
@aditya-bhaumik aditya-bhaumik added gssoc This Contribution is under GSSOC'24 level2 labels Aug 7, 2024
@sk66641 sk66641 merged commit ffccb6e into sk66641:main Aug 7, 2024
2 checks passed
@sk66641
Copy link
Owner

sk66641 commented Aug 7, 2024

@Jasleen1210
it seems you did a lot of work on this issue but unfortunately this change will need to be reverted as there is again the same unidentified error as it was in pr #514 .

@aditya-bhaumik
Copy link
Collaborator

@sk66641 yes i was also getting a similar error thats why i requested for the review

As my network today is not working properly

I thought it was my network problem

@Jasleen1210
Copy link
Contributor Author

Sorry for the error, i still don't get why that error comes though, the changes made in this pr and pr 514 were not related
Ill look into it but please let me know if you have any suggestions or ideas

@aditya-bhaumik aditya-bhaumik removed gssoc This Contribution is under GSSOC'24 level2 labels Aug 7, 2024
@sk66641
Copy link
Owner

sk66641 commented Aug 7, 2024

@Jasleen1210
is this error not occurring in your local machine? then i think it might need to re-fork the repo

@sk66641
Copy link
Owner

sk66641 commented Aug 9, 2024

@Jasleen1210
create another pull request with the same changes, i have tried merging it in my local machine, this time that error was not occuring

@Jasleen1210
Copy link
Contributor Author

Okay, i have re-forked the repo and made similar changes, please review the pr, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Particle effect on side pages
3 participants