Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback scroll #590

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Feedback scroll #590

merged 1 commit into from
Aug 6, 2024

Conversation

Jasleen1210
Copy link
Contributor

#Description
Cause for no scroll was a repeated code snip that caused error
Found a similar repeat in features page so also removed it

Fixes: #576

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Cause for no scroll was a repeated code snip that caused error

Found a similar repeat in features page so also removed it
Copy link

github-actions bot commented Aug 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@aditya-bhaumik
Copy link
Collaborator

aditya-bhaumik commented Aug 5, 2024

@Jasleen1210 share a recording of the new change please is the back to top button still working in these 2 pages

@aditya-bhaumik aditya-bhaumik added gssoc This Contribution is under GSSOC'24 level1 labels Aug 5, 2024
@Jasleen1210
Copy link
Contributor Author

Jasleen1210 commented Aug 5, 2024

Untitled.video.-.Made.with.Clipchamp.1.mp4

@Jasleen1210
Copy link
Contributor Author

The back to top button is working in both pages

@aditya-bhaumik aditya-bhaumik merged commit 4ac3388 into sk66641:main Aug 6, 2024
2 checks passed
@Jasleen1210 Jasleen1210 deleted the scroll-feedback branch August 6, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GSSOC'24 level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Cant scroll on feedback page
2 participants