Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load once #574

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Load once #574

merged 1 commit into from
Aug 5, 2024

Conversation

Jasleen1210
Copy link
Contributor

Description

Added session storage, adjusted nav display as well as warning modal

Fixes: #510

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Copy link

github-actions bot commented Aug 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Jasleen1210
Copy link
Contributor Author

I made changes to a new branch and made sure the prev error is not occurring again, please review and let me know if you are facing it on your browser, thanks! @sk66641 @aditya-bhaumik

@aditya-bhaumik aditya-bhaumik added gssoc This Contribution is under GSSOC'24 level1 labels Aug 5, 2024
@aditya-bhaumik aditya-bhaumik merged commit bf9455c into sk66641:main Aug 5, 2024
2 checks passed
@Jasleen1210
Copy link
Contributor Author

Heyy @aditya-bhaumik,
The labels assigned on the PR and issue are not same, can you please update it? thanks.

@sk66641 sk66641 added level2 and removed level1 labels Aug 5, 2024
@Jasleen1210 Jasleen1210 deleted the session branch August 5, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GSSOC'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Loader: once per session
3 participants