Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addtime alerts #412

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Addtime alerts #412

merged 3 commits into from
Jul 14, 2024

Conversation

Jasleen1210
Copy link
Contributor

Description

Changes:

  • Added an add time modal, decreased the blur during this specific modal so user can see the current counter value too
  • Added remember state so that if the simulation was paused before add time, it remains that way with just an updated counter value
  • Added success and fail notifs with proper css and separate showSuccess() showFail() functions so they can be added in other places too if needed
  • Added the "add time" statement in the modal that shows up at start of simulation
  • Commented properly
    Fixes: Replace 'add time' alerts with better design popups  #380

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

image
image
image

@Jasleen1210
Add time alerts
182e436 
- Added add time modal
- decreased the blur during this specific modal so user can see the current counter value too
- added remember state so that if the simulation was paused before add time, it remains that way with just an updated counter value.
-commented properly
@Jasleen1210
Success failed pop ups
0dbf4e8
@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Jasleen1210
Update
28b1d0d 
Adding back some styles i edited out
@sk66641 sk66641 merged commit fb2e405 into sk66641:main Jul 14, 2024
1 check passed
@sk66641
Copy link
Owner

sk66641 commented Jul 14, 2024

Nice

@sk66641 sk66641 added gssoc This Contribution is under GSSOC'24 level3 labels Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jasleen1210 Jasleen1210

Labels
gssoc This Contribution is under GSSOC'24 level3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace 'add time' alerts with better design popups
2 participants
@Jasleen1210 @sk66641