disabling negative inputs #22
Conversation
|
Thank you @Tapesh-1308 for your contribution! but could you please create an issue first describing the problem or feature this PR addresses? Once the issue is created, we can link it to this PR and proceed further. |
|
Ok, but we can still enter a negative input using keyboard i think, i tried it just now |
|
@sk66641 Yes, you are right. Today, I've realized that the min/max attribute in HTML can be easily bypassed by inputting values from the keyboard. This means that JavaScript validation is still necessary, so my pull request doesn't make sense anymore. I'm going to close the pull request. I'm really sorry for the time I've taken from you. However, this doesn't discourage me. I will continue to contribute to the project. Thank you |
|
@Tapesh-1308 No worries at all! Closing a pull request when you realize it’s not necessary or relevant is a responsible approach. Keep up the good work! 😊 |
Since we don't need negative input, there is no need to enable users to enter them. Therefore, I have disabled negative input by setting the minimum number as 0.