Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 105 Fixed #133

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Issue 105 Fixed #133

merged 3 commits into from
Jun 3, 2024

Conversation

BHS-Harish
Copy link
Contributor

Issue #105 Fixed

Improvement : Replay option added at the end

bandicam.2024-06-02.15-24-25-354.mp4

Copy link

github-actions bot commented Jun 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sk66641
Copy link
Owner

sk66641 commented Jun 2, 2024

@BHS-Harish
can you checked it once if it's working, when i tried it's not working.

@sk66641
Copy link
Owner

sk66641 commented Jun 2, 2024

@BHS-Harish
ok , i got it ! it works after timer has finished . So, can also replace alert with this replay popup otherwise there'll be too many popups.

@BHS-Harish can you checked it once if it's working, when i tried it's not working.

@BHS-Harish
Copy link
Contributor Author

Hey @sk66641 bro Now the alert showed for first time when we submit the form only. At the end, the replay popup only shown.

@sk66641 sk66641 merged commit ed54af3 into sk66641:main Jun 3, 2024
1 check passed
@sk66641 sk66641 added gssoc This Contribution is under GSSOC'24 level1 labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GSSOC'24 level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants