Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added preloader #129

Merged
merged 4 commits into from
Jun 3, 2024
Merged

added preloader #129

merged 4 commits into from
Jun 3, 2024

Conversation

Jagpreet153
Copy link
Contributor

Fixes : #60
I have added preloader to this site it is completely responsive. Have a look . Kindly assign this PR to me and add gssoc and level tags.

Untitled9.mp4

Copy link

github-actions bot commented Jun 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sk66641
Copy link
Owner

sk66641 commented Jun 2, 2024

@Jagpreet153
there is an issue with the stars moving in the background as it's not visible

@Jagpreet153
Copy link
Contributor Author

@sk66641 I think you are talking about the snowflakes and stars . It was not an issue as I thought that the snowflakes would be in the page loading section . However I have made changes please have a look .

Untitled12.mp4

@sk66641
Copy link
Owner

sk66641 commented Jun 3, 2024

@Jagpreet153 Ok

@sk66641 sk66641 merged commit c148641 into sk66641:main Jun 3, 2024
@sk66641 sk66641 added gssoc This Contribution is under GSSOC'24 level2 labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GSSOC'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preloader
2 participants