Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar and Phrasing Improvements in Inputs Section #164

Closed
ishap11 opened this issue Jun 5, 2024 · 14 comments
Closed

Grammar and Phrasing Improvements in Inputs Section #164

ishap11 opened this issue Jun 5, 2024 · 14 comments
Assignees
Labels
gssoc This Contribution is under GSSOC'24

Comments

@ishap11
Copy link
Contributor

ishap11 commented Jun 5, 2024

Hello, my name is Isha Prajapati.
I noticed some small grammar and phrasing issues in the Inputs section of our documentation. Here are the changes I'd like to make:

Current: "How many random colors you want to be shown?"
Proposed: "How many random colors do you want to be shown?"

Current: "Select your desired start & end colors for the gradient"
Proposed: "Select your desired start & end colors for the gradient."

Current: "With how much time interval (in milliseconds) you want to change the colors randomly?"
Proposed: "With what time interval (in milliseconds) do you want to change the colors randomly?"

Current: "What type of view you want to choose (conic, linear or radial)?"
Proposed: "What type of view do you want to choose (conic, linear, or radial)?"

Current: "Countdown timer (in seconds)"
Proposed: "Set the countdown timer (in seconds)."

Screenshot 2024-06-05 163044

I'm eager to contribute under GSSOC'24 and would like to request the assignment of this task.
Thank you!

Copy link

github-actions bot commented Jun 5, 2024

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

@ishap11
Copy link
Contributor Author

ishap11 commented Jun 6, 2024

I've submitted a new pull request with the changes I've made. Please take a look and review it.
" Resolved Issues in the Inputs Section #1 "
Thank you!

@sk66641
Copy link
Owner

sk66641 commented Jun 6, 2024

I've submitted a new pull request with the changes I've made. Please take a look and review it. " Resolved Issues in the Inputs Section #1 " Thank you!

@Coding-whiz
Can you guide him @ishap11 ? She has sent a pull request in her forked repository.

@Coding-whiz
Copy link
Collaborator

Coding-whiz commented Jun 7, 2024 via email

@sk66641
Copy link
Owner

sk66641 commented Jun 7, 2024

Hi, If it isn't urgent may I look into this after 10pm today?I am quite busy right now. Do let me know if it is urgent.

@Coding-whiz
ok

@Coding-whiz
Copy link
Collaborator

I've submitted a new pull request with the changes I've made. Please take a look and review it. " Resolved Issues in the Inputs Section #1 " Thank you!

Hi,

The changes you suggested for the README file are appropriate, and I appreciate your attention to detail. Since you're in the learning stage of open source contribution, I recommend drafting a comprehensive README file with basic styling. Once you've drafted it, you can get it reviewed.
I look forward to seeing more of your contributions!🌸

@sk66641
Copy link
Owner

sk66641 commented Jun 7, 2024

@ishap11
To know more about creating a pull request, you can checkout Learn.md

@ishap11
Copy link
Contributor Author

ishap11 commented Jun 8, 2024

Thanks! I’ll check out the Learn.md file.

@ishap11
Copy link
Contributor Author

ishap11 commented Jun 10, 2024

Hi,
Sorry for the late reply. Thank you for your feedback and guidance! I'll work on the README file and send it over for review soon.
Thanks for your patience and support.

Copy link

Hello @ishap11! Your issue #164 has been closed. Thank you for your contribution!

@ishap11
Copy link
Contributor Author

ishap11 commented Jun 13, 2024

Hello @sk66641 and @Coding-whiz,
I noticed that the pull request for the README enhancements was closed but not merged. Could you please provide some feedback on what needs to be improved or why it wasn't merged?

I am eager to learn and make the necessary changes to contribute effectively.
Thank you for your guidance and support!

@sk66641 sk66641 reopened this Jun 13, 2024
@sk66641
Copy link
Owner

sk66641 commented Jun 13, 2024

@ishap11
you have again created a PR in your forked repository! So, how can i merge it. I understand it happens when we are in the learning phase. So, i have reopened this issue, you can take your time.

@ishap11
Copy link
Contributor Author

ishap11 commented Jun 14, 2024

Thank you for reopening the issue. I've created a PR in the main repository for your review. Please let me know if any changes are needed.

@sk66641 sk66641 closed this as completed Jun 14, 2024
Copy link

Hello @ishap11! Your issue #164 has been closed. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GSSOC'24
Projects
None yet
Development

No branches or pull requests

3 participants