This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
fix: hiding discovery on Akkoma + hiding privacy settings #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks :3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in my previous PR for hiding the discovery page on Akkoma where it would still show if the instance info hadn't been fetched before it tried to find out if it should hide discovery. It seems like it always will have this info when running onCreateView for the discovery fragment instead of onCreate for the home fragment
New settings were introduced recently for some new Mastodon privacy options, but Akkoma doesn't have these. It does have one that's similar that's also called discoverable, but it's located in a different place in the API, and it's also not fully the same. From my understanding, Mastodon's setting is about Mastodon search while Akkoma's is about external search engines, so the setting would probably need a different implementation in Megalodon for it to make sense to show it, and so I think it should be hidden at least for now