Merge pull request #29 from sjjian/alter_table_constraint_ast

support alter table constraint ast
sjjian · Dec 24, 2021 · 793d6d1 · 793d6d1
2 parents b5a4d36 + a04f759
commit 793d6d1
Show file tree

Hide file tree

Showing 6 changed files with 94 additions and 22 deletions.
diff --git a/README.md b/README.md
@@ -8,10 +8,10 @@ this is an oracle sql parser. ref: https://docs.oracle.com/en/database/oracle/or
 |Alter table|Modify column| :heavy_check_mark:|:heavy_check_mark:|
 |Alter table|Drop column| :heavy_check_mark:|:heavy_check_mark:|
 |Alter table|Rename column| :heavy_check_mark:|:heavy_check_mark:|
-|Alter table|Add constraint| :heavy_check_mark:| |
-|Alter table|Modify constraint| :heavy_check_mark:| |
-|Alter table|Rename constraint| :heavy_check_mark:| |
-|Alter table|Drop constraint| :heavy_check_mark:| |
+|Alter table|Add constraint| :heavy_check_mark:| :heavy_check_mark:|
+|Alter table|Modify constraint| :heavy_check_mark:| :heavy_check_mark:|
+|Alter table|Rename constraint| :heavy_check_mark:| :heavy_check_mark:|
+|Alter table|Drop constraint| :heavy_check_mark:| :heavy_check_mark:|
 |Create table|Relational table|:heavy_check_mark:|:heavy_check_mark:|
 |Create index|Relational table|:heavy_check_mark:| |
 |Drop table|-|:heavy_check_mark:|:heavy_check_mark:|

diff --git a/ast/base.go b/ast/base.go
@@ -39,7 +39,8 @@ type ColumnDefault struct {
 type ConstraintType int
 
 const (
-	ConstraintTypeNull ConstraintType = iota
+	ConstraintTypeDefault ConstraintType = iota
+	ConstraintTypeNull
 	ConstraintTypeNotNull
 	ConstraintTypeUnique
 	ConstraintTypePK

diff --git a/ast/ddl.go b/ast/ddl.go
@@ -49,18 +49,23 @@ type RenameColumnClause struct {
 
 type AddConstraintClause struct {
 	alterTableClause
+	Constraints []*OutOfLineConstraint
 }
 
 type ModifyConstraintClause struct {
 	alterTableClause
+	Constraint *OutOfLineConstraint
 }
 
 type RenameConstraintClause struct {
 	alterTableClause
+	OldName *element.Identifier
+	NewName *element.Identifier
 }
 
 type DropConstraintClause struct {
 	alterTableClause
+	Constraint *OutOfLineConstraint
 }
 
 /*
@@ -132,4 +137,4 @@ type DropTableStmt struct {
 type DropIndexStmt struct {
 	node
 	IndexName *IndexName
-}
+}
diff --git a/sql.go b/sql.go
diff --git a/sql.y b/sql.y
@@ -1162,24 +1162,42 @@ RenameColumnClause:
 ConstraintClauses:
     _add OutOfLineConstraint // Note: in docs is _add OutOfLineConstraints, but actual is _add OutOfLineConstraint.
     {
-    	$$ = []ast.AlterTableClause{&ast.AddConstraintClause{}}
+        $$ = []ast.AlterTableClause{&ast.AddConstraintClause{
+               Constraints: []*ast.OutOfLineConstraint{$2.(*ast.OutOfLineConstraint)},
+        }}
     }
 //|   _add OutOfLineRefConstraint
 |   _modify _constraint Identifier ConstraintState CascadeOrEmpty
     {
-    	$$ = []ast.AlterTableClause{&ast.ModifyConstraintClause{}}
+        constraint := &ast.OutOfLineConstraint{}
+        constraint.Name = $3.(*element.Identifier)
+        $$ = []ast.AlterTableClause{&ast.ModifyConstraintClause{
+            Constraint: constraint,
+        }}
     }
 |   _modify _primary _key ConstraintState CascadeOrEmpty
     {
-    	$$ = []ast.AlterTableClause{&ast.ModifyConstraintClause{}}
+        constraint := &ast.OutOfLineConstraint{}
+        constraint.Type = ast.ConstraintTypePK
+        $$ = []ast.AlterTableClause{&ast.ModifyConstraintClause{
+            Constraint: constraint,
+        }}
     }
 |   _modify _unique '(' ColumnNameList ')' ConstraintState CascadeOrEmpty
     {
-    	$$ = []ast.AlterTableClause{&ast.ModifyConstraintClause{}}
+        constraint := &ast.OutOfLineConstraint{}
+        constraint.Type = ast.ConstraintTypeUnique
+        constraint.Columns = $4.([]*element.Identifier)
+        $$ = []ast.AlterTableClause{&ast.ModifyConstraintClause{
+            Constraint: constraint,
+        }}
     }
 |   _rename _constraint Identifier _to Identifier
     {
-    	$$ = []ast.AlterTableClause{&ast.RenameConstraintClause{}}
+    	$$ = []ast.AlterTableClause{&ast.RenameConstraintClause{
+    	    OldName: $3.(*element.Identifier),
+    	    NewName: $5.(*element.Identifier),
+    	}}
     }
 |   DropConstraintClauses
     {
@@ -1203,15 +1221,28 @@ DropConstraintClauses:
 DropConstraintClause:
     _drop _primary _key CascadeOrEmpty DropConstraintProps
     {
-    	$$ = &ast.DropConstraintClause{}
+        constraint := &ast.OutOfLineConstraint{}
+        constraint.Type = ast.ConstraintTypePK
+        $$ = &ast.DropConstraintClause{
+            Constraint: constraint,
+        }
     }
 |   _drop _unique '(' ColumnNameList ')' CascadeOrEmpty DropConstraintProps
     {
-    	$$ = &ast.DropConstraintClause{}
+        constraint := &ast.OutOfLineConstraint{}
+        constraint.Type = ast.ConstraintTypeUnique
+        constraint.Columns = $4.([]*element.Identifier)
+        $$ = &ast.DropConstraintClause{
+            Constraint: constraint,
+        }
     }
 |   _drop _constraint Identifier CascadeOrEmpty DropConstraintProps
     {
-    	$$ = &ast.DropConstraintClause{}
+        constraint := &ast.OutOfLineConstraint{}
+        constraint.Name = $3.(*element.Identifier)
+        $$ = &ast.DropConstraintClause{
+            Constraint: constraint,
+        }
     }
 
 CascadeOrEmpty:

diff --git a/test/alter_table_constraint.sql b/test/alter_table_constraint.sql
@@ -16,6 +16,10 @@ alter table db1.table1 modify primary key using index;
 
 alter table db1.table1 modify primary key rely using index idx_1 enable validate;
 
+alter table db1.table1 modify constraint idx_1 using index;
+
+alter table db1.table1 modify unique(name,age) using index;
+
 alter table db1.table1 drop primary key keep index;
 
 alter table db1.table1 drop primary key keep index drop unique(name,age) drop index;