Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emoji): https://github.com/siyuan-note/siyuan/issues/13509 #13585

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Dec 22, 2024

fix #13509

目前的顺序:加载下方的 emoji → 跳转 → 加载上方的 emoji ,就会导致定位偏移。

改进为先加载上方的 emoji 再加载下方的 emoji,最后跳转

@Vanessa219
Copy link
Member

我在 mac 上和 Windows 上都重现不了

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 23, 2024

不清楚,反正这样改之后能解决我这里出现的问题

@Vanessa219 Vanessa219 merged commit 1b05bb9 into siyuan-note:dev Jan 6, 2025
1 check passed
@TCOTC TCOTC deleted the dev-emoji branch January 6, 2025 09:41
Vanessa219 added a commit that referenced this pull request Jan 6, 2025
@Vanessa219
Copy link
Member

我重构了下,由于无法重现,还麻烦你再看看。

@Vanessa219
Copy link
Member

3.1.19

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 6, 2025

没问题

EightDoor added a commit to EightDoor/siyuan that referenced this pull request Jan 8, 2025
* commit '56f8ea4ab9d59cb9e3f0e907c0deb2909f30f32c': (186 commits)
  🔖 Release v3.1.19
  🐛 Loading certain font files causes kernel panic siyuan-note#13739
  📝 Update changelogs
  🚨
  📝 Update changelogs
  🎨 siyuan-note#13725
  🐛 Loading certain font files causes kernel panic siyuan-note#13739
  🐛 Loading certain font files causes kernel panic siyuan-note#13739
  🎨 Improve the window size settings after application restarts siyuan-note#13732
  ♻️ siyuan-note#13585
  fix(emoji): siyuan-note#13509 (siyuan-note#13585)
  🎨 siyuan-note#13664
  🐛 Fix a npe
  🎨 Improve display reference counts in the backlink panel siyuan-note#13678
  🎨 Clean code
  🎨 siyuan-note#13667
  🎨 siyuan-note#13719
  🎨 siyuan-note#13719
  🎨 siyuan-note#13716
  🎨 siyuan-note#13716
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants