Add event method support #59
Conversation
… Also add more details about DogStatsD to the readme.
| @@ -175,10 +228,10 @@ Client.prototype.sendAll = function(stat, value, type, sampleRate, tags, callbac | |||
|
|
|||
| if(Array.isArray(stat)){ | |||
| stat.forEach(function(item){ | |||
| self.send(item, value, type, sampleRate, tags, onSend); | |||
| self.sendStat(item, value, type, sampleRate, tags, onSend); | |||
There was a problem hiding this comment.
I had to split the existing send method in two, and the part that is applicable to both events and stats is now called send().
|
Any thoughts on this? I see that there's a couple of pull request sitting around, and I'm not sure what to do here. I would really like to get this into a couple of projects at work and have it come from npm rather than the git URL I use when I have to. Is node-statsd still being updated, or is there an actively-maintained fork to contribute this to? If the answer is "no" to those two, do you want more maintainers here or a fork to be created? I'd be happy to pitch in some way or other. |
|
I've pulled this into a different repo I'm going to help maintain so we can get a bunch of the PRs in here. https://github.com/brightcove/hot-shots |
This is a reworking of mrbar42#11 to fit into node-statsd and fix up a few things in the event support.
With this addition, the only thing missing for DogStatsD is service checks. I've also tried to make clearer the DogStatsD support in the README. If/when this is pulled in, I'll submit a pull request to node-dogstatsd to direct people to just use node-statsd from now on.