This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
Added thrown error when cacheDNS flag fails to resolve dns name #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been biting me, I assumed this would be the fix too. Any chance of this being merged any time soon? It's killing my 6 hour-ish long process over and over. I will just cache for now, didn't realise that was an option. |
|
Excuse my intrusion here, but nothing has been merged in this project for a long time. I started https://github.com/brightcove/hot-shots because of this, which includes this change. |
|
Ah, didn't realise this wasn't being maintained, thanks for the heads up, @bdeitte! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Some justification for this throw:
Currently if the user passes a hostname to options.host without the cache flag on, the module will try to resolve the DNS name during runtime when the user tries to use any statsd function. The issue here is that if the DNS server cannot be reached, the server will crash.
The cacheDns flag allows an elegant way to allow users to opt out of this behavior. As long as the DNS name was successfully resolved when the module is initialized, the module will not cause the application to crash if DNS is not reachable.
To further reinforce this behavior, I think the the cacheDns lookup should immediately throw if the user passes an invalid hostname during initialization.