Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change implementation method signature to declare type is int #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davidolesch
Copy link

Fixed conflicting parameter types.

Fixed conflicting parameter types.
@davidolesch
Copy link
Author

The method signatures are different in the header and implementation files.

@siuying
Copy link
Owner

siuying commented Feb 4, 2016

Thanks for point out this.

I changed the header file to use type int because, unless I remove the import #import <libxml2/libxml/HTMLparser.h>, Swift will throw a compiler error about module. I'll see if there is a proper solution for this.

Meanwhile, I believe the right change should be using int instead of htmlParserOption in the implementation file.

@davidolesch
Copy link
Author

@siuying that should work too 👍

@davidolesch davidolesch changed the title Update IGHTMLDocument.h Change implementation method signature to declare type is int Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants