Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pro 3691 #445

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feature/pro 3691 #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81ef475
fix TTS values documentation
Dec 3, 2024
4b128b2
changelog unreleased
Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG_UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- fix OnSpeakAloudTextResult params values documentation
9 changes: 6 additions & 3 deletions lib/src/definitions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,13 +304,16 @@ class OnSpeakAloudTextResult {
/// A [String] that represents the language code, i.e. es-ES
final String? lang;

/// A [Double] that represents the volume from 0.0 to 1.0
/// A [Double] that represents the volume from 0.0 to 1.0, default 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eu prefería que aparecera aquí especificado o que é menos, máis, lento, rápido, etc. Pero de todas formas o enlace á documentación é útil.

Ahora ben, ollo porque en dart docs os enlaces van entre corchetes:

/// Para máis información, consulta Google.

/// https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesisUtterance/volume
final double? volume;

/// A [Double] that represents the speech pitch from 0.0 to 1.0
/// A [Double] that represents the speech pitch from 0.0 to 2.0, default 1
/// https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesisUtterance/pitch
final double? pitch;

/// A [Double] that represents the speech rate from 0.0 to 1.0
/// A [Double] that represents the speech rate from 0.0 to 10.0, default 1
/// https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesisUtterance/rate
final double? rate;

const OnSpeakAloudTextResult(
Expand Down