-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: QMCkl #85
Draft
addman2
wants to merge
65
commits into
sissaschool:devel
Choose a base branch
from
addman2:qmckl_new_again
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Draft: QMCkl #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addman2
requested review from
kousuke-nakano and
michele-casula
as code owners
January 19, 2024 10:15
Dear @addman2, hi! I wonder if I could merge this pull-request. Is it still in progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a fan of a big changes but this is a big one. Many things are intertwined and was hard to deliver them separately.
Makefun.f90
was (partly) refactored. Now separate orbital are stored indevel_tools/makefun_factory
. executingconstruct.py
one can build makefun.Consisting of title line 1. Parameters out of which only
angmom
,npar
andmulticiplity
are necessary (lines 3 -8). Continued by any doc string (lines 10 onwards). These headers than can be used for generating documentation.3. New test added for makefun testing:
Here is a sample output: