-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security vulnerability fixes and multi arch support #763
base: master
Are you sure you want to change the base?
Conversation
Dockerfile
Outdated
@@ -48,6 +48,7 @@ RUN apt-get update && \ | |||
tesseract-ocr-sqi \ | |||
&& apt-get clean && \ | |||
rm -rf /var/lib/apt/lists/* | |||
RUN apt-get update && apt-get upgrade libgnutls30 -y -q |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you merge this with the previous command?
Also, what is this package for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @jendib libgnutls30 is a package in the GnuTLS library suite, specifically version 3. GnuTLS is a secure communications library implementing the SSL, TLS, and DTLS protocols. The primary purpose of libgnutls30 is to provide support for cryptographic algorithms and protocols necessary to secure network communications.
I think this package is used by the OS internally in the version used as it popped in the security vulnerability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also merged the command to above line
HI @jendib this has been in this state for quite some time. Can you please do another review? |
<com.google.guava.guava.version>31.1-jre</com.google.guava.guava.version> | ||
<log4j.log4j.version>1.2.17</log4j.log4j.version> | ||
<com.google.guava.guava.version>33.0.0-jre</com.google.guava.guava.version> | ||
<log4j.log4j.version>2.22.1</log4j.log4j.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the log4j version is upgraded to the major version 2, and reload4j is a log4j 1 fork, so there is a problem.
<org.slf4j.jcl-over-slf4j.version>1.7.30</org.slf4j.jcl-over-slf4j.version> | ||
<org.slf4j.jul-to-slf4j.version>1.7.30</org.slf4j.jul-to-slf4j.version> | ||
<junit.junit.version>4.13.2</junit.junit.version> | ||
<com.h2database.h2.version>1.4.199</com.h2database.h2.version> | ||
<com.h2database.h2.version>2.2.224</com.h2database.h2.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to break all existing instances using h2 database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jendib we have been working with this version of h2 in our forked teedy without any issues. However let me know and I can revert both this and the log4j version change. But there will still be vulnerabilities for these older versions
Hi @jendib this PR consists vulnerability fixes and multi arch support