add better handling of empty or broken views

sinnbeck · Oct 22, 2022 · f254bb0 · f254bb0
1 parent cfff92e
commit f254bb0
Show file tree

Hide file tree

Showing 9 changed files with 83 additions and 3 deletions.
diff --git a/src/Macros/AssertElementMacro.php b/src/Macros/AssertElementMacro.php
@@ -13,7 +13,16 @@ public function __invoke()
     {
         return function ($selector = 'body', $callback = null): TestResponse {
             /** @var TestResponse $this */
-            $parser = DomParser::new($this->getContent());
+            Assert::assertNotEmpty(
+                $this->getContent(),
+                'The view is empty!'
+            );
+
+            try {
+                $parser = DomParser::new($this->getContent());
+            } catch (\DOMException $exception) {
+                Assert::fail($exception->getMessage());
+            }
 
             if (is_callable($selector)) {
                 $callback = $selector;

diff --git a/src/Macros/AssertFormMacro.php b/src/Macros/AssertFormMacro.php
@@ -13,7 +13,16 @@ public function __invoke()
     {
         return function ($selector = 'form', $callback = null): TestResponse {
             /** @var TestResponse $this */
-            $parser = DomParser::new($this->getContent());
+            Assert::assertNotEmpty(
+                $this->getContent(),
+                'The view is empty!'
+            );
+
+            try {
+                $parser = DomParser::new($this->getContent());
+            } catch (\DOMException $exception) {
+                Assert::fail($exception->getMessage());
+            }
 
             if (is_callable($selector)) {
                 $callback = $selector;

diff --git a/src/Parsers/DomParser.php b/src/Parsers/DomParser.php
@@ -31,7 +31,11 @@ public function setContent($html): void
 
         $html = '<?xml encoding="UTF-8">'.trim($html);
         $dom->loadHTML($html, LIBXML_NOERROR | LIBXML_COMPACT | LIBXML_HTML_NODEFDTD | LIBXML_NOBLANKS | LIBXML_NOXMLDECL);
-        $this->setRoot($dom->getElementsByTagName('body')->item(0));
+        $root = $dom->getElementsByTagName('body')->item(0);
+        if (is_null($root)) {
+            throw new \DOMException('No body element found!');
+        }
+        $this->setRoot($root);
     }
 
     public function getElementOfType(string $type, $index = 0): ?DOMNode

diff --git a/tests/DomParserTest.php b/tests/DomParserTest.php
@@ -34,6 +34,7 @@
     $parser->setRoot($parser->query('#form2'));
 
     $this->assertNotNull($parser->query('select:nth-of-type(2)'));
+    $this->assertNotNull($parser->query('input'));
 });
 
 it('can get an attribute', function () {

diff --git a/tests/DomTest.php b/tests/DomTest.php
@@ -3,6 +3,29 @@
 use PHPUnit\Framework\AssertionFailedError;
 use Sinnbeck\DomAssertions\Asserts\ElementAssert;
 
+it('can handle an empty view', function () {
+    $this->get('empty')
+        ->assertElement();
+})->throws(
+    AssertionFailedError::class,
+    'The view is empty!'
+);
+
+it('can handle an empty body', function () {
+    $this->get('empty-body')
+        ->assertElement();
+})->throws(
+    AssertionFailedError::class,
+    'No body element found!'
+);
+
+it('can parse broken html', function () {
+    $this->get('broken')
+        ->assertElement(function ($d) {
+            $d->dd();
+        });
+});
+
 it('can find the an element', function () {
     $this->get('nesting')
         ->assertElement();

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -23,5 +23,8 @@ protected function defineRoutes($router)
     {
         Route::view('form', 'form');
         Route::view('nesting', 'nesting');
+        Route::view('empty', 'empty');
+        Route::view('empty-body', 'empty-body');
+        Route::view('broken', 'broken');
     }
 }
diff --git a/tests/views/broken.php b/tests/views/broken.php
@@ -0,0 +1,21 @@
+<!doctype html>
+<html lang="en">
+    <head>
+        <meta charset="UTF-8">
+        <meta name="viewport"
+              content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
+        <meta http-equiv="X-UA-Compatible" content="ie=edge">
+        <title>Document</title>
+    </head>
+    <body>
+        <div>
+            <div class="foo">
+                <span></span>
+                <span></span>
+                <span><p></p>
+                <table>
+                    <td><div></div></td>
+                </table>
+        </div>
+    </body>
+</html>
diff --git a/tests/views/empty-body.blade.php b/tests/views/empty-body.blade.php
@@ -0,0 +1,10 @@
+<!doctype html>
+<html lang="en">
+    <head>
+        <meta charset="UTF-8">
+        <meta name="viewport"
+              content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
+        <meta http-equiv="X-UA-Compatible" content="ie=edge">
+        <title>Document</title>
+    </head>
+</html>
diff --git a/tests/views/empty.blade.php b/tests/views/empty.blade.php