Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NOx and SO2 adjustments #365

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix NOx and SO2 adjustments #365

wants to merge 1 commit into from

Conversation

grgmiller
Copy link
Collaborator

@grgmiller grgmiller commented May 21, 2024

Purpose

In pre-2012 data, there are several data availability issues that may affect the quality of SO2 and NOx data:

  • do we have boiler type data for nox calculations?
  • EIA-923 emissions controls data: pre 2012
  • do we have sulfur content data
  • Missing fuel-PM-firing combinations in the NOX and SO2 factors

What the code is doing

How is the purpose executed?

Testing

How did you test this change (unit/functional testing, manual testing, etc.)?

Where to look

  • It's helpful to clarify where your new code lives if you moved files around or there could be confusion/

  • What files are most important?

Usage Example/Visuals

How the code can be used and/or images of any graphs, tables or other visuals (not always applicable).

Review estimate

How long will it take for reviewers and observers to understand this code change?

Future work

What issues were identified that are not being addressed in this PR but should be addressed in future work?

Checklist

  • Update the documentation to reflect changes made in this PR
  • Format all updated python files using black
  • Clear outputs from all notebooks modified
  • Add docstrings and type hints to any new functions created

@grgmiller grgmiller changed the base branch from main to historical_coverage_feature May 21, 2024 22:44
Base automatically changed from historical_coverage_feature to main August 1, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant