Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for detection of head, left, right connections at switches #46

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

lpirl
Copy link
Contributor

@lpirl lpirl commented Nov 13, 2024

This adds a test for the calculation of "Anschluss" (head, left, right) of a switch. The test contains some base scenarios (think: a switch rotated in steps of 45°) and therefrom derived scenarios (think: the switch moved around in the coordinate system). The derived scenarios are the ones actually being tested. The test reveals actual defects (probably also #41, not quite sure). Thanks for considering.

@lpirl lpirl requested a review from arneboockmeyer November 13, 2024 00:29
@lpirl lpirl force-pushed the add-test-for-head-detection-of-switches branch 2 times, most recently from bcf4f25 to 3b5ba6c Compare November 13, 2024 13:02
@lpirl lpirl force-pushed the add-test-for-head-detection-of-switches branch from 3b5ba6c to c8dd4bc Compare November 13, 2024 13:37
test/node_test.py Show resolved Hide resolved
@lpirl
Copy link
Contributor Author

lpirl commented Dec 2, 2024

thanks for linting, @arneboockmeyer

@arneboockmeyer arneboockmeyer merged commit 886b7b2 into main Dec 2, 2024
1 of 2 checks passed
@arneboockmeyer arneboockmeyer deleted the add-test-for-head-detection-of-switches branch December 2, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants