Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_switch by also checking the graph degree #60

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix is_switch by also checking the graph degree #60

merged 1 commit into from
May 22, 2024

Conversation

arneboockmeyer
Copy link
Member

No description provided.

@arneboockmeyer arneboockmeyer requested a review from lpirl May 22, 2024 15:48
@lpirl
Copy link
Contributor

lpirl commented May 22, 2024

Great! Happy to merge.

Considering the law of Demeter, I wonder if the module utils should know about networkx.Graph at all. Currently, it's only is_end_node and now also is_switch needing the node degree. To remove the coupling between the modules networkx and utils, we could also hand the node degree to those two procedures directly. If you think it's worth it, we could open an issue to address this.

@lpirl lpirl merged commit 38c9859 into main May 22, 2024
0 of 2 checks passed
@lpirl lpirl deleted the fix-is-switch branch May 22, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpirl lpirl lpirl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arneboockmeyer @lpirl