(SIMP-10376) Fix simpkv plugin API issues #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two simpkv plugin API issues found when developing the LDAP plugin
* Fixed the mechanism a plugin uses to advertise its type.
- Plugin type is now determined from its filename.
- Previous mechanism did not work when when multiple plugins were used.
It erroneously used a class method `type`, which for each anonymous
plugin class, polluted the Class object namespace, instead of being
associated with its anonymous class.
* Changed the plugin configuration API
- Configuration has been split out into its own method, instead of being
done in the plugin constructor.
- This minimal change simplifies unit testing of configuration of complex
plugins.
SIMP-10376 #close
trevor-vaughan
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two simpkv plugin API issues found when developing the LDAP plugin
It erroneously used a class method
type, which for each anonymousplugin class, polluted the Class object namespace, instead of being
associated with its anonymous class.
done in the plugin constructor.
plugins.
SIMP-10376 #close