Skip to content

Clean up for rubocop #66

Clean up for rubocop

Clean up for rubocop #66

Triggered via pull request December 13, 2024 22:14
Status Failure
Total duration 1m 50s
Artifacts

pr_tests.yml

on: pull_request
Matrix: Puppet Spec
Fit to window
Zoom out
Zoom in

Annotations

15 errors and 7 warnings
RELENG checks
Process completed with exit code 1.
Ruby Style: lib/puppet_x/simpkv/file_plugin.rb#L106
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet_x/simpkv/file_plugin.rb#L132
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet_x/simpkv/file_plugin.rb#L203
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet_x/simpkv/file_plugin.rb#L318
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet_x/simpkv/file_plugin.rb#L340
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - `path`.
Ruby Style: lib/puppet_x/simpkv/file_plugin.rb#L394
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet_x/simpkv/file_plugin.rb#L407
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet_x/simpkv/file_plugin.rb#L423
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet_x/simpkv/simpkv.rb#L114
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet_x/simpkv/simpkv.rb#L140
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Puppet Spec (Puppet 7.x [SIMP 6.6/PE 2021.7], ~> 7.0, 2.7, false): spec/functions/simpkv/delete_spec.rb#L58
simpkv::delete basic operation deletes an existing key in a specific backend in options Failure/Error: is_expected.to run.with_params(key, @options_test_file).and_return(true) expected simpkv::delete("mykey", {"backends"=>{"test_failer"=>{"id"=>"test", "type"=>"failer", "fail_constructor"=>false}, "test_file"=>{"id"=>"test", "type"=>"file", "root_path"=>"/tmp/d20241213-1848-io4m3v/simpkv/test_file"}, "myapp"=>{"id"=>"default_app_id", "type"=>"file", "root_path"=>"/tmp/d20241213-1848-io4m3v/simpkv/default_app_id"}, "default"=>{"id"=>"default", "type"=>"file", "root_path"=>"/tmp/d20241213-1848-io4m3v/simpkv/default"}}, "backend"=>"test_file"}) to have returned true instead of raising NoMethodError(undefined method `attr_reader' for #<Puppet::Resource::Catalog:0x0000555651a8df20>) /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/spec/fixtures/modules/simpkv/lib/puppet_x/simpkv/loader.rb:21:in `load' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/spec/fixtures/modules/simpkv/lib/puppet/functions/simpkv/support/load.rb:22:in `instance_eval' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/spec/fixtures/modules/simpkv/lib/puppet/functions/simpkv/support/load.rb:22:in `load' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/dispatch.rb:60:in `invoke' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/dispatcher.rb:47:in `block in dispatch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/dispatcher.rb:46:in `catch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/dispatcher.rb:46:in `dispatch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/function.rb:43:in `block in call' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/function.rb:42:in `catch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/function.rb:42:in `call' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/function.rb:117:in `block in internal_call_function' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/util/profiler/around_profiler.rb:58:in `profile' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/util/profiler.rb:51:in `profile' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/function.rb:116:in `internal_call_function' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/function.rb:71:in `call_function' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/spec/fixtures/modules/simpkv/lib/puppet/functions/simpkv/delete.rb:103:in `delete' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/dispatch.rb:60:in `invoke' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/dispatcher.rb:47:in `block in dispatch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/dispatcher.rb:46:in `catch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/dispatcher.rb:46:in `dispatch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/2.7.0/gems/puppet-7.34.0/lib/puppet/pops/functions/function.rb:43:in `block in call' /ho
Puppet Spec (Puppet 7.x [SIMP 6.6/PE 2021.7], ~> 7.0, 2.7, false)
Process completed with exit code 1.
Puppet Spec (Puppet 8.x, ~> 8.0, 3.2, false): spec/functions/simpkv/delete_spec.rb#L58
simpkv::delete basic operation deletes an existing key in a specific backend in options Failure/Error: is_expected.to run.with_params(key, @options_test_file).and_return(true) expected simpkv::delete("mykey", {"backends"=>{"test_failer"=>{"id"=>"test", "type"=>"failer", "fail_constructor"=>false}, "test_file"=>{"id"=>"test", "type"=>"file", "root_path"=>"/tmp/d20241213-2390-a5dv9/simpkv/test_file"}, "myapp"=>{"id"=>"default_app_id", "type"=>"file", "root_path"=>"/tmp/d20241213-2390-a5dv9/simpkv/default_app_id"}, "default"=>{"id"=>"default", "type"=>"file", "root_path"=>"/tmp/d20241213-2390-a5dv9/simpkv/default"}}, "backend"=>"test_file"}) to have returned true instead of raising NoMethodError(undefined method `attr_reader' for #<Puppet::Resource::Catalog:0x00007f7e8763c9e8 @in_to={Stage[main]{:name=>"main"}=>{}, Class[Settings]{:name=>"Settings"}=>{Stage[main]{:name=>"main"}=>[{ Stage[main] => Class[Settings] }]}, Class[main]{:name=>"main"}=>{Stage[main]{:name=>"main"}=>[{ Stage[main] => Class[main] }]}}, @out_from={Stage[main]{:name=>"main"}=>{Class[Settings]{:name=>"Settings"}=>[{ Stage[main] => Class[Settings] }], Class[main]{:name=>"main"}=>[{ Stage[main] => Class[main] }]}, Class[Settings]{:name=>"Settings"}=>{}, Class[main]{:name=>"main"}=>{}}, @upstream_from={}, @downstream_from={}, @name="fv-az1771-572.2ylvbwgxy3nupokun4gfpak4pb.dx.internal.cloudapp.net", @catalog_uuid="3c212f49-32cc-4fb4-b936-0069fd243250", @catalog_format=2, @metadata={}, @recursive_metadata={}, @classes=["settings"], @resource_table={["Stage", "main"]=>Stage[main]{:name=>"main"}, ["Class", "Settings"]=>Class[Settings]{:name=>"Settings"}, ["Class", "main"]=>Class[main]{:name=>"main"}}, @resources=[["Stage", "main"], ["Class", "Settings"], ["Class", "main"]], @relationship_graph=nil, @host_config=true, @environment_instance=<Puppet::Node::Environment:12820 @name="myenv" @manifest="/home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/spec/fixtures/manifests" @modulepath="/home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/spec/fixtures/modules" >, @Environment="myenv", @code_id=nil, @Aliases={}, @Version=1734128191, @tags=#<Puppet::Util::TagSet: {"settings"}>, @client_version="8.10.0", @server_version=nil>) /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/spec/fixtures/modules/simpkv/lib/puppet_x/simpkv/loader.rb:21:in `load' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/spec/fixtures/modules/simpkv/lib/puppet/functions/simpkv/support/load.rb:22:in `instance_eval' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/spec/fixtures/modules/simpkv/lib/puppet/functions/simpkv/support/load.rb:22:in `load' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/3.2.0/gems/puppet-8.10.0/lib/puppet/pops/functions/dispatch.rb:62:in `invoke' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/3.2.0/gems/puppet-8.10.0/lib/puppet/pops/functions/dispatcher.rb:48:in `block in dispatch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/3.2.0/gems/puppet-8.10.0/lib/puppet/pops/functions/dispatcher.rb:47:in `catch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/3.2.0/gems/puppet-8.10.0/lib/puppet/pops/functions/dispatcher.rb:47:in `dispatch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/3.2.0/gems/puppet-8.10.0/lib/puppet/pops/functions/function.rb:44:in `block in call' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/3.2.0/gems/puppet-8.10.0/lib/puppet/pops/functions/function.rb:43:in `catch' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/3.2.0/gems/puppet-8.10.0/lib/puppet/pops/functions/function.rb:43:in `call' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/3.2.0/gems/puppet-8.10.0/lib/puppet/pops/functions/function.rb:116:in `block in internal_call_function' /home/runner/work/pupmod-simp-simpkv/pupmod-simp-simpkv/vendor/bundle/ruby/3.2.0/gems/puppet-8.10.0/lib/puppet/util/profiler/around_profiler.rb:59:
Puppet Spec (Puppet 8.x, ~> 8.0, 3.2, false)
Process completed with exit code 1.
RELENG checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Puppet Syntax
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Puppet Style
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
File checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Ruby Style
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Puppet Spec (Puppet 7.x [SIMP 6.6/PE 2021.7], ~> 7.0, 2.7, false)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Puppet Spec (Puppet 8.x, ~> 8.0, 3.2, false)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636