Clean up for rubocop (#68)

* Clean up for rubocop * Additional cleanup
simp · Dec 17, 2024 · 43343b8 · 43343b8
1 parent 0e18365
commit 43343b8
Show file tree

Hide file tree

Showing 10 changed files with 756 additions and 66 deletions.
diff --git a/.github/workflows/pr_tests.yml b/.github/workflows/pr_tests.yml
@@ -35,7 +35,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - name: "Install Ruby ${{matrix.puppet.ruby_version}}"
+      - name: "Install Ruby 2.7"
         uses: ruby/setup-ruby@v1  # ruby/setup-ruby@ec106b438a1ff6ff109590de34ddc62c540232e0
         with:
           ruby-version: 2.7
@@ -47,7 +47,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - name: "Install Ruby ${{matrix.puppet.ruby_version}}"
+      - name: "Install Ruby 2.7"
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: 2.7
@@ -56,13 +56,12 @@ jobs:
       - run: "bundle exec rake metadata_lint"
 
   ruby-style:
-    if: false # TODO Modules will need: rubocop in Gemfile, .rubocop.yml
-    name: 'Ruby Style (experimental)'
+    name: 'Ruby Style'
     runs-on: ubuntu-latest
     continue-on-error: true
     steps:
       - uses: actions/checkout@v3
-      - name: "Install Ruby ${{matrix.puppet.ruby_version}}"
+      - name: "Install Ruby 2.7"
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: 2.7
@@ -89,7 +88,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - name: 'Install Ruby ${{matrix.puppet.ruby_version}}'
+      - name: 'Install Ruby 2.7'
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: 2.7