Skip to content

Commit

Permalink
Removes puppet 6 from .gitlab-ci.yml (#67)
Browse files Browse the repository at this point in the history
  • Loading branch information
rgardner4012 authored May 23, 2023
1 parent 1d78656 commit 2493ec3
Show file tree
Hide file tree
Showing 4 changed files with 64 additions and 70 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/pr_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ on:
types: [opened, reopened, synchronize]

env:
PUPPET_VERSION: '~> 6'
PUPPET_VERSION: '~> 7'

jobs:
puppet-syntax:
Expand All @@ -38,7 +38,7 @@ jobs:
- name: "Install Ruby ${{matrix.puppet.ruby_version}}"
uses: ruby/setup-ruby@v1 # ruby/setup-ruby@ec106b438a1ff6ff109590de34ddc62c540232e0
with:
ruby-version: 2.5
ruby-version: 2.7
bundler-cache: true
- run: "bundle exec rake syntax"

Expand All @@ -50,7 +50,7 @@ jobs:
- name: "Install Ruby ${{matrix.puppet.ruby_version}}"
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.5
ruby-version: 2.7
bundler-cache: true
- run: "bundle exec rake lint"
- run: "bundle exec rake metadata_lint"
Expand All @@ -65,7 +65,7 @@ jobs:
- name: "Install Ruby ${{matrix.puppet.ruby_version}}"
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.5
ruby-version: 2.7
bundler-cache: true
- run: |
bundle show
Expand All @@ -76,10 +76,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: 'Install Ruby 2.5'
- name: 'Install Ruby 2.7'
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.5
ruby-version: 2.7
bundler-cache: true
- run: bundle exec rake check:dot_underscore
- run: bundle exec rake check:test_file
Expand All @@ -92,7 +92,7 @@ jobs:
- name: 'Install Ruby ${{matrix.puppet.ruby_version}}'
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.5
ruby-version: 2.7
bundler-cache: true
- name: 'Tags and changelogs'
run: |
Expand All @@ -109,12 +109,12 @@ jobs:
strategy:
matrix:
puppet:
- label: 'Puppet 6.22 [SIMP 6.6/PE 2019.8]'
puppet_version: '~> 6.22.1'
ruby_version: '2.5'
- label: 'Puppet 7.x'
puppet_version: '~> 7.0'
puppet_version: '~> 7.21.0'
ruby_version: '2.7'
- label: 'Puppet 8.x'
puppet_version: '~> 8.0'
ruby_version: '3.2'
env:
PUPPET_VERSION: '${{matrix.puppet.puppet_version}}'
steps:
Expand Down
84 changes: 42 additions & 42 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -232,27 +232,27 @@ variables:
# Puppet Versions
#-----------------------------------------------------------------------

.pup_6_x: &pup_6_x
image: 'ruby:2.5'
variables:
PUPPET_VERSION: '~> 6.0'
BEAKER_PUPPET_COLLECTION: 'puppet6'
MATRIX_RUBY_VERSION: '2.5'

.pup_6_pe: &pup_6_pe
image: 'ruby:2.5'
variables:
PUPPET_VERSION: '6.22.1'
BEAKER_PUPPET_COLLECTION: 'puppet6'
MATRIX_RUBY_VERSION: '2.5'

.pup_7_x: &pup_7_x
image: 'ruby:2.7'
variables:
PUPPET_VERSION: '~> 7.0'
BEAKER_PUPPET_COLLECTION: 'puppet7'
MATRIX_RUBY_VERSION: '2.7'

.pup_7_pe: &pup_7_pe
image: 'ruby:2.7'
variables:
PUPPET_VERSION: '7.21.0'
BEAKER_PUPPET_COLLECTION: 'puppet7'
MATRIX_RUBY_VERSION: '2.7'

.pup_8_x: &pup_8_x
image: 'ruby:3.2'
variables:
PUPPET_VERSION: '~> 8.0'
BEAKER_PUPPET_COLLECTION: 'puppet8'
MATRIX_RUBY_VERSION: '3.2'



# Testing Environments
Expand Down Expand Up @@ -302,7 +302,7 @@ variables:
#=======================================================================

releng_checks:
<<: *pup_6_x
<<: *pup_7_x
<<: *setup_bundler_env
stage: 'validation'
tags: ['docker']
Expand All @@ -325,24 +325,24 @@ releng_checks:
# different Puppet versions won't accomplish anything.

pup-lint:
<<: *pup_6_x
<<: *pup_7_x
<<: *lint_tests

# Unit Tests
#-----------------------------------------------------------------------

pup6.x-unit:
<<: *pup_6_x
pup7.x-unit:
<<: *pup_7_x
<<: *unit_tests
<<: *with_SIMP_SPEC_MATRIX_LEVEL_2

pup6.pe-unit:
<<: *pup_6_pe
pup7.pe-unit:
<<: *pup_7_pe
<<: *unit_tests

pup7.x-unit:
<<: *pup_7_x
<<: *unit_tests
#pup8.x-unit:
# <<: *pup_8_x
# <<: *unit_tests

# ------------------------------------------------------------------------------
# NOTICE: **This file is maintained with puppetsync**
Expand All @@ -354,51 +354,51 @@ pup7.x-unit:
# Repo-specific content
# ==============================================================================

pup6.x:
<<: *pup_6_x
pup7.x:
<<: *pup_7_x
<<: *acceptance_base
script:
- 'bundle exec rake beaker:suites[default,default]'

pup6.x-fips:
<<: *pup_6_x
pup7.x-fips:
<<: *pup_7_x
<<: *acceptance_base
script:
- 'BEAKER_fips=yes bundle exec rake beaker:suites[default,default]'

pup6.pe:
<<: *pup_6_pe
pup7.pe:
<<: *pup_7_pe
<<: *acceptance_base
script:
- 'bundle exec rake beaker:suites[default,default]'

pup6.pe-fips:
<<: *pup_6_pe
pup7.pe-fips:
<<: *pup_7_pe
<<: *acceptance_base
script:
- 'BEAKER_fips=yes bundle exec rake beaker:suites[default,default]'

pup6.pe-oel:
<<: *pup_6_pe
pup7.pe-oel:
<<: *pup_7_pe
<<: *acceptance_base
script:
- 'bundle exec rake beaker:suites[default,oel]'

pup6.pe-amzn2:
<<: *pup_6_pe
pup7.pe-amzn2:
<<: *pup_7_pe
<<: *acceptance_base
script:
- 'bundle exec rake beaker:suites[default,amzn2]'

pup6.pe-oel-fips:
<<: *pup_6_pe
pup7.pe-oel-fips:
<<: *pup_7_pe
<<: *acceptance_base
<<: *with_SIMP_ACCEPTANCE_MATRIX_LEVEL_3
script:
- 'BEAKER_fips=yes bundle exec rake beaker:suites[default,oel]'

pup7.x:
<<: *pup_7_x
<<: *acceptance_base
script:
- 'bundle exec rake beaker:suites[default,default]'
#pup8.x:
# <<: *pup_8_x
# <<: *acceptance_base
# script:
# - 'bundle exec rake beaker:suites[default,default]'
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ENV['PDK_DISABLE_ANALYTICS'] ||= 'true'
gem_sources.each { |gem_source| source gem_source }

group :test do
puppet_version = ENV['PUPPET_VERSION'] || '~> 6.22'
puppet_version = ENV['PUPPET_VERSION'] || '~> 7'
major_puppet_version = puppet_version.scan(/(\d+)(?:\.|\Z)/).flatten.first.to_i
gem 'rake'
gem 'puppet', puppet_version
Expand Down
26 changes: 10 additions & 16 deletions spec/acceptance/nodesets/oel.yml
Original file line number Diff line number Diff line change
@@ -1,28 +1,22 @@
<%
if ENV['BEAKER_HYPERVISOR']
hypervisor = ENV['BEAKER_HYPERVISOR']
else
hypervisor = 'vagrant'
end
-%>
---
HOSTS:
oel7:
roles:
- default
- default
platform: el-7-x86_64
box: generic/oracle7
hypervisor: <%= hypervisor %>

hypervisor: "<%= ENV.fetch('BEAKER_HYPERVISOR', 'vagrant') %>"
family: sicura-image-build/oracle-linux-7
gce_machine_type: n1-standard-2
oel8:
platform: el-8-x86_64
box: generic/oracle8
hypervisor: <%= hypervisor %>

hypervisor: "<%= ENV.fetch('BEAKER_HYPERVISOR', 'vagrant') %>"
family: sicura-image-build/oracle-linux-8
gce_machine_type: n1-standard-2
CONFIG:
log_level: verbose
synced_folder : disabled
synced_folder: disabled
type: aio
vagrant_memsize: 256
<% if ENV['BEAKER_PUPPET_COLLECTION'] -%>
puppet_collection: <%= ENV['BEAKER_PUPPET_COLLECTION'] %>
<% end -%>
puppet_collection: "<%= ENV.fetch('BEAKER_PUPPET_COLLECTION', 'puppet7') %>"

0 comments on commit 2493ec3

Please sign in to comment.