-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to define a selection of MouseButtons to ignore #216
Conversation
Thank you very much, what do you think of swapping the option into explicitly listing buttons via |
That is probably the more correct approach considering the approach that is taken in the rest of the config (enabling over disabling). The current implementation ensures backwards compatibility. Consumers of this package may safely update the dependency without having to tweak existing code, I'd say that the decision is up to you given that you're the main maintainer :^) I'd gladly contribute such a change if you decide to go for it, I could also add support for modifier buttons (such that e.g. only |
Yeah, I didn't really follow semver considering this is one of my oldest projects. I'd actually take the breaking change in exchange for a cleaner config and add a note in the release notes.
That'd be awesome, not sure how I'd represent these combination in the config though - this can quickly get complicated if you, for example, only want to have to press |
This commit makes it possible for consumers of this package to define more complex inputs that trigger the selection; e.g. Control + Shift + Left-mouse-button A mouse-button is always required while the modifiers are optional.
Take a look at how I've structured the config and let me know if you'd like any changes. It might also be a good idea to use strings ( Edit; on second thought, I'm really now sure whether strings would be better as that may give the impression that the library provides it's own definitions of mouse buttons and that it maps it to the space of |
Thank you very much for your contribution, I'll release a new version soon with these changes :) Happy holidays! |
Replaces #214