Skip to content

Commit

Permalink
updated for version 7.4.289
Browse files Browse the repository at this point in the history
Problem:    Pattern with repeated backreference does not match with new regexp
            engine. (Urtica Dioica)
Solution:   Also check the end of a submatch when deciding to put a state in
            the state list.
  • Loading branch information
brammool committed May 13, 2014
1 parent be578ed commit ee48253
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 0 deletions.
31 changes: 31 additions & 0 deletions src/regexp_nfa.c
Original file line number Diff line number Diff line change
Expand Up @@ -3945,6 +3945,7 @@ copy_ze_off(to, from)

/*
* Return TRUE if "sub1" and "sub2" have the same start positions.
* When using back-references also check the end position.
*/
static int
sub_equal(sub1, sub2)
Expand Down Expand Up @@ -3976,6 +3977,23 @@ sub_equal(sub1, sub2)
if (s1 != -1 && sub1->list.multi[i].start.col
!= sub2->list.multi[i].start.col)
return FALSE;

if (nfa_has_backref)
{
if (i < sub1->in_use)
s1 = sub1->list.multi[i].end.lnum;
else
s1 = -1;
if (i < sub2->in_use)
s2 = sub2->list.multi[i].end.lnum;
else
s2 = -1;
if (s1 != s2)
return FALSE;
if (s1 != -1 && sub1->list.multi[i].end.col
!= sub2->list.multi[i].end.col)
return FALSE;
}
}
}
else
Expand All @@ -3992,6 +4010,19 @@ sub_equal(sub1, sub2)
sp2 = NULL;
if (sp1 != sp2)
return FALSE;
if (nfa_has_backref)
{
if (i < sub1->in_use)
sp1 = sub1->list.line[i].end;
else
sp1 = NULL;
if (i < sub2->in_use)
sp2 = sub2->list.line[i].end;
else
sp2 = NULL;
if (sp1 != sp2)
return FALSE;
}
}
}

Expand Down
1 change: 1 addition & 0 deletions src/testdir/test64.in
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ STARTTEST
:call add(tl, [2, '^.*\.\(.*\)/.\+\(\1\)\@<=$', 'foo.bat/foo.bat', 'foo.bat/foo.bat', 'bat', 'bat'])
:call add(tl, [2, '\\\@<!\${\(\d\+\%(:.\{-}\)\?\\\@<!\)}', '2013-06-27${0}', '${0}', '0'])
:call add(tl, [2, '^\(a*\)\1$', 'aaaaaaaa', 'aaaaaaaa', 'aaaa'])
:call add(tl, [2, '^\(a\{-2,}\)\1\+$', 'aaaaaaaaa', 'aaaaaaaaa', 'aaa'])
:"
:"""" Look-behind with limit
:call add(tl, [2, '<\@<=span.', 'xxspanxx<spanyyy', 'spany'])
Expand Down
3 changes: 3 additions & 0 deletions src/testdir/test64.ok
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,9 @@ OK 2 - \\\@<!\${\(\d\+\%(:.\{-}\)\?\\\@<!\)}
OK 0 - ^\(a*\)\1$
OK 1 - ^\(a*\)\1$
OK 2 - ^\(a*\)\1$
OK 0 - ^\(a\{-2,}\)\1\+$
OK 1 - ^\(a\{-2,}\)\1\+$
OK 2 - ^\(a\{-2,}\)\1\+$
OK 0 - <\@<=span.
OK 1 - <\@<=span.
OK 2 - <\@<=span.
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
289,
/**/
288,
/**/
Expand Down

0 comments on commit ee48253

Please sign in to comment.