-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SimdJsonParser2 base on bitindex #60
base: main
Are you sure you want to change the base?
Conversation
5c92d47
to
3139b2c
Compare
e84e78d
to
e2f0def
Compare
@arouel thanks very much, I have fix the code based on your suggestion. Benchmark testing indicators. refer: Result "org.simdjson.AParseAndSelectFixPathBenchMark.parseMultiValuesForFixPaths_Jackson": Result "org.simdjson.ParseAndSelectFixPathBenchMark.parseMultiValuesForFixPaths_SimdJson": Result "org.simdjson.ParseAndSelectFixPathBenchMark.parseMultiValuesForFixPaths_SimdJsonParserWithFixPath": |
e2f0def
to
4bed300
Compare
How is this different from On-Demand parsing available in the c++ simdjson version? I introduced a form of on-demand parsing in #51 (see: |
@piotrrzysko I agree with you, a DOM-like API ( Can you guide us a bit, so that we can prepare a PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heykirby I just want share some thoughts/questions:
With some minor API changes in simdjson-java
, could we keep the SimdJsonParserWithFixPath
in another codebase or it could life in a contribution module, because it is tailored for a very specific use case?
Isn't a record JsonNode
sufficient compared to using lombok
?
ecd8e0e
to
204fed7
Compare
@arouel Thanks arouel,the unused imports has been removed |
204fed7
to
f6fc9e5
Compare
hello, piotrrzysko, I used on-demand parsing,it is very convenient and efficient to deserialize json strings into java classes.it is also a solution provided by many mainstream json sdk. For SimdJsonParserWithFixPath, if we want get values for multi-paths: [$.a.c,$.a,$.a.d,$.b], we only need to provide the json paths, the usage is similar to hive's user define function: json_tuple. It also supports obtaining the value of the children of the container object while obtaining the compressed string value of the container object. |
Hi, sorry for the delayed reply. @heykirby The schema-based API you’re referring to is simply using logic that could potentially be utilized by the on-demand DOM API as well.
I’d be happy to help. Perhaps I could start by creating a skeleton of the on-demand DOM API. |
thanks,piotrrzysko, It's always an expected feature. |
@piotrrzysko I submitted a new PR, could you give me some guidance? #63 |
issue: #59