FIX Ensure no admin routed links are affected by versioning #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Nov 14, 2024
Comment on lines
-75
to
+82
| $liveClientConfig = $controller->getClientConfig(); | ||
| $liveClientConfig = $controller->getCombinedClientConfig(); |
There was a problem hiding this comment.
Using getCombinedClientConfig instead of getClientConfig to expand the breadth of the test. This should have been picked up back in silverstripe/silverstripe-admin#1761 but wasn't because the test wasn't looking wide enough.
Note this expansion is also why we now need a request with a session above.
emteknetnz
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was originally introduced in #173 and is intended to avoid adding stage params to any
admin/*routed URL (which used to be theoretically restricted to LeftAndMain subclasses).Issue
LeftAndMaininto its own abstract class silverstripe-admin#1762