Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Incomplete data fix (missing some versioned history records). #70

Merged
merged 1 commit into from
Oct 11, 2023
Merged

BUG: Incomplete data fix (missing some versioned history records). #70

merged 1 commit into from
Oct 11, 2023

Conversation

mfendeksilverstripe
Copy link
Collaborator

@mfendeksilverstripe mfendeksilverstripe commented Oct 10, 2023 •
edited
Loading

BUG: Incomplete data fix (missing some versioned history records).

  • fixed an issue with activity feed when we have incomplete versioned history data
  • this is a valid case as old versioned history data may get deleted so we need to support this case
  • extensibility improvements (remove static method)
  • minor code cleanup

@mfendeksilverstripe mfendeksilverstripe added the bug Something isn't working label Oct 10, 2023
aria5305
aria5305 approved these changes Oct 11, 2023
View reviewed changes
Copy link

@aria5305 aria5305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mfendeksilverstripe mfendeksilverstripe merged commit eb6b6a2 into 1 Oct 11, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aria5305 aria5305 aria5305 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfendeksilverstripe @aria5305