ENH Allow File.keep_archived_assets to show files archive tab #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/1.13/config
branch
from
ac0f183 to
bcc4ffb
Compare
GuySartorelli
requested changes
Aug 7, 2023
emteknetnz
force-pushed
the
pulls/1.13/config
branch
from
bcc4ffb to
addd992
Compare
GuySartorelli
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #300
This should have been checked
File.keep_archived_assetsall along, instead of AssetControlExtensionAssetControlExtension is an extension added to DataObject which is how the
keep_archived_assetsconfig is on File, so I can see why people though the config should have been read from there, though I think it was an error. We should that config working though for BCDocumentation has it on File - https://docs.silverstripe.org/en/4/developer_guides/files/file_management/#configuring-file-archiving
All the unit-tests that reference 'keep_archived_assets' use
File::config()->set('keep_archived_assets')