Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Highlight paragraph changes in diff. #237

Merged
merged 1 commit into from
Apr 11, 2022
Merged

FIX Highlight paragraph changes in diff. #237

merged 1 commit into from
Apr 11, 2022

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Apr 10, 2022 •
edited
Loading

Changes which affect entire paragraphs (or any other block-level elements) were not being highlighted because the ins and del elements are treated as display:inline; by default.

Parent issue

@GuySartorelli GuySartorelli mentioned this pull request Apr 10, 2022
Closed
2 tasks
@GuySartorelli GuySartorelli linked an issue Apr 10, 2022 that may be closed by this pull request
Compare diff isn't working #212
Closed
2 tasks
emteknetnz
emteknetnz approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally, works great

@emteknetnz emteknetnz merged commit d13bb65 into silverstripe:1.10 Apr 11, 2022
@emteknetnz emteknetnz deleted the pulls/1.10/diff-styling branch April 11, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compare diff isn't working
2 participants
@GuySartorelli @emteknetnz