FIX Allow no recordId to be passed in to avoid console error in dev (#…

…347)
silverstripe · Jun 18, 2024 · 0c02307 · 0c02307
1 parent d1fd54e
commit 0c02307
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/client/dist/js/bundle.js b/client/dist/js/bundle.js
diff --git a/client/src/components/HistoryViewer/HistoryViewer.js b/client/src/components/HistoryViewer/HistoryViewer.js
@@ -368,7 +368,11 @@ class HistoryViewer extends Component {
   }
 
   render() {
-    const { loading, compare, currentVersion } = this.props;
+    const { loading, compare, currentVersion, recordId } = this.props;
+
+    if (!recordId) {
+      return null;
+    }
 
     if (loading) {
       return <Loading />;
@@ -391,7 +395,7 @@ HistoryViewer.propTypes = {
   limit: PropTypes.number,
   ListComponent: PropTypes.elementType.isRequired,
   offset: PropTypes.number,
-  recordId: PropTypes.number.isRequired,
+  recordId: PropTypes.number,
   currentVersion: PropTypes.oneOfType([PropTypes.bool, versionType]),
   compare: compareType,
   isInGridField: PropTypes.bool,