API Update code to reflect changes in silverstripe/cms #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2024
GuySartorelli
force-pushed
the
pulls/7.0/generic-cmsmain
branch
from
279ca6e to
609cbb3
Compare
GuySartorelli
force-pushed
the
pulls/7.0/generic-cmsmain
branch
from
609cbb3 to
48bdee9
Compare
GuySartorelli
commented
Dec 11, 2024
Comment on lines
-233
to
-240
| // Revert to checking for a form from the session | ||
| // LeftAndMain::sessionNamespace is protected. | ||
| $sessionNamespace = $this->config()->get('session_namespace') ?: CMSMain::class; | ||
|
|
||
| $formID = Controller::curr()->getRequest()->getSession()->get($sessionNamespace . '.currentPage'); | ||
| if ($formID) { | ||
| return UserDefinedForm::get()->byID($formID); | ||
| } |
There was a problem hiding this comment.
Storing the current record ID in the session was deprecated, and is being removed in silverstripe/silverstripe-admin#1867
From what I can tell, the relation is always set anyway so we shouldn't ever get to this.
emteknetnz
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1339
Reflects changes in silverstripe/silverstripe-admin#1837 and silverstripe/silverstripe-framework#11439
Issue
SiteTreeinCMSMainsilverstripe-cms#2947