ENH Scaffold TaxonomyTerm with searchable dropdown #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jun 19, 2024
| @@ -63,33 +69,33 @@ class TaxonomyTerm extends DataObject implements PermissionProvider | |||
|
|
|||
| public function getCMSFields() | |||
| { | |||
| $fields = parent::getCMSFields(); | |||
| $this->beforeUpdateCMSFields(function (FieldList $fields) { | |||
There was a problem hiding this comment.
Wrapping the implementation in beforeUpdateCMSFields() is best practice. This is partially unrelated refactoring, but it also is necessary to make sure the Children field is a gridfield before extension hooks fire, which will keep those functioning the same before and after this change.
There was a problem hiding this comment.
All other changes to this method (unless otherwise stated) are just explicitly using a GridField for the Children relation, instead of the auto-scaffolded searchable dropdown.
GuySartorelli
commented
Jun 19, 2024
GuySartorelli
commented
Jun 19, 2024
6 tasks
emteknetnz
previously requested changes
Jun 26, 2024
emteknetnz
dismissed
their stale review
I mistakently compared in to CMS 5 instead of CMS 6
emteknetnz
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue