ENH Add generic types (#277)

silverstripe · Jan 23, 2024 · 556772b · 556772b
1 parent 0e3d8ca
commit 556772b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/StringTagField.php b/src/StringTagField.php
@@ -219,7 +219,7 @@ protected function getSuggestURL()
     }
 
     /**
-     * @return ArrayList
+     * @return ArrayList<ArrayData>
      */
     protected function getOptions()
     {
@@ -356,7 +356,6 @@ protected function getTags($term)
     {
         $items = [];
         foreach ($this->getOptions() as $i => $tag) {
-            /** @var ArrayData $tag */
             $tagValue = $tag->Value;
             // Map into a distinct list (prevent duplicates)
             if (stripos($tagValue ?? '', $term ?? '') !== false && !array_key_exists($tagValue, $items ?? [])) {

diff --git a/src/TagField.php b/src/TagField.php
@@ -257,7 +257,7 @@ protected function getSuggestURL()
     }
 
     /**
-     * @return ArrayList
+     * @return ArrayList<ArrayData>
      */
     protected function getOptions($onlySelected = false)
     {
@@ -582,7 +582,6 @@ public function validate($validator)
      */
     public function performReadonlyTransformation()
     {
-        /** @var ReadonlyTagField $copy */
         $copy = $this->castedCopy(ReadonlyTagField::class);
         $copy->setSourceList($this->getSourceList());
         $copy->setTitleField($this->getTitleField());