API Update code to reflect changes to LeftAndMain #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Dec 8, 2024
Comment on lines
-54
to
-56
| SilverStripe\CMS\Controllers\CMSPagesController: | ||
| extensions: | ||
| - SilverStripe\Subsites\Extensions\SubsiteMenuExtension |
There was a problem hiding this comment.
This is already included on CMSMain above.
7 tasks
GuySartorelli
force-pushed
the
pulls/4.0/generic-cmsmain
branch
2 times, most recently
from
7457a98 to
a46ca42
Compare
GuySartorelli
commented
Dec 11, 2024
Comment on lines
-285
to
-291
| // Clear current page when subsite changes (or is set for the first time) | ||
| if ($state->getSubsiteIdWasChanged()) { | ||
| // sessionNamespace() is protected - see for info | ||
| $override = $this->owner->config()->get('session_namespace'); | ||
| $sessionNamespace = $override ? $override : get_class($this->owner); | ||
| $session->clear($sessionNamespace . '.currentPage'); | ||
| } |
There was a problem hiding this comment.
Storing the current record ID in the session was deprecated, and is being removed in silverstripe/silverstripe-admin#1867
GuySartorelli
force-pushed
the
pulls/4.0/generic-cmsmain
branch
from
a46ca42 to
07f30f6
Compare
emteknetnz
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #604
Reflects changes in silverstripe/silverstripe-admin#1837
Issue
SiteTreeinCMSMainsilverstripe-cms#2947