Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Update unit test #209

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Oct 17, 2024

Issue silverstripe/.github#320

Location header ended up as http://example.com/silverstripe.org - url is missing a scheme and I think the http://example.com came from an alternate_base_url being set elsewhere

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 096eca8 into silverstripe:7 Oct 22, 2024
7 checks passed
@GuySartorelli GuySartorelli deleted the pulls/7/unit-test branch October 22, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants